salival Posted March 12, 2017 Author Report Share Posted March 12, 2017 9 hours ago, Jim90 said: The Skin_Functionary1_EP1_DZ (Donald) used by the global banker is being sold at clothes.hpp class Category_628, line 12. I remember in 1051 that if a player put on a trader skin that it allowed allowed other players to use him as a trader. If 1.0.6.1 works the same, then that skin should be removed from the traders (and the server loot tables). As @icomrade mentions below, I'm already doing a check to see if it's a player so this wont happen. (I copied the epoch traders stuff for this) Link to comment Share on other sites More sharing options...
icomrade Posted March 12, 2017 Report Share Posted March 12, 2017 56 minutes ago, salival said: I just copied @JasonTMexample for that, but I'll change it when I get home from work. Cheers. you could add a isplayer check and avoid the whole skin shenanigance in the future Edit: There is actually one salival 1 Link to comment Share on other sites More sharing options...
Jim90 Posted March 13, 2017 Report Share Posted March 13, 2017 I tried adding the Infostand_2_EP1 to the DZE_MoneyStorageClasses in variables.sqf as per the instructions (see below) but do not get the selection for banking when scrolling on it. Has anyone else out there got this working? Thanks for the help. DZE_MoneyStorageClasses = DZE_LockableStorage + ["Infostand_2_EP1"]; Here is how I added the infostand. if (isServer) then { _vehicle_908 = objNull; //Stary if (true) then { _this = createVehicle ["Infostand_2_EP1", [6325.58,7799.75,0.001], [], 0, "CAN_COLLIDE"]; _vehicle_908 = _this; _this setDir 307.3; _this setPos [6325.58,7799.75,0.001]; }; } Link to comment Share on other sites More sharing options...
salival Posted March 13, 2017 Author Report Share Posted March 13, 2017 3 hours ago, Jim90 said: I tried adding the Infostand_2_EP1 to the DZE_MoneyStorageClasses in variables.sqf as per the instructions (see below) but do not get the selection for banking when scrolling on it. Has anyone else out there got this working? Thanks for the help. DZE_MoneyStorageClasses = DZE_LockableStorage + ["Infostand_2_EP1"]; Here is how I added the infostand. if (isServer) then { _vehicle_908 = objNull; //Stary if (true) then { _this = createVehicle ["Infostand_2_EP1", [6325.58,7799.75,0.001], [], 0, "CAN_COLLIDE"]; _vehicle_908 = _this; _this setDir 307.3; _this setPos [6325.58,7799.75,0.001]; }; } DZE_moneyStorageClasses is only for saving coins for the specific player. You want this variable: ZSC_bankObjects = [""]; // Array of objects that are available for banking (i.e Suitcase, Info_Board_EP1) Link to comment Share on other sites More sharing options...
SKS.Goliath Posted March 13, 2017 Report Share Posted March 13, 2017 Comes the update for the bank global online? Link to comment Share on other sites More sharing options...
salival Posted March 13, 2017 Author Report Share Posted March 13, 2017 1 hour ago, SKS.Goliath said: Comes the update for the bank global online? Link to comment Share on other sites More sharing options...
Anhor Posted March 13, 2017 Report Share Posted March 13, 2017 What have I done wrong? 21:51:24 Warning Message: Script z\addons\dayz_server\init\server_functions.sqf not found 21:51:24 Warning Message: Script z\addons\dayz_server\compile\server_spawnTraders.sqf not found 21:51:24 "Loading custom server compiles" 21:51:25 Warning Message: Script z\addons\dayz_server\system\dynamic_vehicle.sqf not found 21:51:25 Warning Message: Script z\addons\dayz_server\system\server_monitor.sqf not found 21:51:25 Warning Message: Script z\addons\dayz_server\traders\takistan.sqf not found 21:51:25 Error in expression <; _recompile = (count _this) > 0; if (BIS_fnc_init && !_recompile) exitwith {t> 21:51:25 Error position: <BIS_fnc_init && !_recompile) exitwith {t> 21:51:25 Error Undefined variable in expression: bis_fnc_init 21:51:25 File ca\Modules\Functions\init.sqf, line 28 21:51:25 "z\addons\dayz_code\system\REsec.sqf:Monitoring Remote Exe..." Link to comment Share on other sites More sharing options...
Anhor Posted March 13, 2017 Report Share Posted March 13, 2017 Solved. Link to comment Share on other sites More sharing options...
OMGitzSteveo Posted March 14, 2017 Report Share Posted March 14, 2017 This works nice very good job. My only issue is i can't scroll wheel on the added NPC banker. No errors in RPT for a lead. Anyone else experienced this / know where i may have gone wrong? Link to comment Share on other sites More sharing options...
salival Posted March 14, 2017 Author Report Share Posted March 14, 2017 38 minutes ago, OMGitzSteveo said: This works nice very good job. My only issue is i can't scroll wheel on the added NPC banker. No errors in RPT for a lead. Anyone else experienced this / know where i may have gone wrong? Hi, I'm using the same code for the Npc banker as epoch uses for normal traders. Try setting the ZSC_bankTraders variable to one of the skins a trader is using then go see that trader and see if it works. Link to comment Share on other sites More sharing options...
salival Posted March 14, 2017 Author Report Share Posted March 14, 2017 Also, I fixed 2 undefined variables in the fn_selfActions file this morning a few hours ago, be sure to update if it needs it, could fix that problem Link to comment Share on other sites More sharing options...
carl101 Posted March 14, 2017 Report Share Posted March 14, 2017 hi guys, can i get a little help please, I am getting no option in game to deposit coins, i have coins on person etc, can trade, have the bank icon up but just no option to deposit or withdraw. only error i am getting is this which is spammed in local rpt Error in expression <rTarget in DZE_MoneyStorageClasses && {!_isLocked} && !(_typeOfCursorTarget in D> Error position: <_isLocked} && !(_typeOfCursorTarget in D> Error Undefined variable in expression: _islocked File mpmissions\__CUR_MP.chernarus\dayz_code\compile\fn_selfActions.sqf, line 941 Error in expression <rTarget in DZE_MoneyStorageClasses && {!_isLocked} && !(_typeOfCursorTarget in D> Error position: <_isLocked} && !(_typeOfCursorTarget in D> Error Undefined variable in expression: _islocked File mpmissions\__CUR_MP.chernarus\dayz_code\compile\fn_selfActions.sqf, line 941 Error in expression <rTarget in DZE_MoneyStorageClasses && {!_isLocked} && !(_typeOfCursorTarget in D> Error position: <_isLocked} && !(_typeOfCursorTarget in D> Error Undefined variable in expression: _islocked File mpmissions\__CUR_MP.chernarus\dayz_code\compile\fn_selfActions.sqf, line 941 Error in expression <rTarget in DZE_MoneyStorageClasses && {!_isLocked} && !(_typeOfCursorTarget in D> Error position: <_isLocked} && !(_typeOfCursorTarget in D> Error Undefined variable in expression: _islocked File mpmissions\__CUR_MP.chernarus\dayz_code\compile\fn_selfActions.sqf, line 941 its on a fresh install using the files from github that section from fn-self Spoiler // Custom below _isAnimal = _cursorTarget isKindOf "Animal"; if (_isMan && {!_isAlive} && {!_isAnimal} && {player distance _cursorTarget < 5}) then { if (s_player_checkWallet < 0) then { s_player_checkWallet = player addAction ["Check Wallet","scripts\zsc\checkWallet.sqf",_cursorTarget,0,false,true]; }; } else { player removeAction s_player_checkWallet; s_player_checkWallet = -1; }; if (_typeOfCursorTarget in DZE_MoneyStorageClasses && {!_isLocked} && !(_typeOfCursorTarget in DZE_LockedStorage) && {_isDistance}) then { if (s_bank_dialog < 0) then { s_bank_dialog = player addAction ["Access bank","scripts\zsc\bankDialog.sqf",_cursorTarget,1,true,true]; }; } else { player removeAction s_bank_dialog; s_bank_dialog = -1; }; if (_isAlive && {_typeOfCursorTarget in AllPlayers} && {isPlayer _cursorTarget}) then { if (s_givemoney_dialog < 0) then { s_givemoney_dialog = player addAction [format ["Trade %1 with %2",CurrencyName,name _cursorTarget],"scripts\zsc\givePlayer.sqf",_cursorTarget,3,true,true]; }; } else { player removeAction s_givemoney_dialog; s_givemoney_dialog = -1; }; thanks Link to comment Share on other sites More sharing options...
salival Posted March 14, 2017 Author Report Share Posted March 14, 2017 25 minutes ago, carl101 said: hi guys, can i get a little help please, I am getting no option in game to deposit coins, i have coins on person etc, can trade, have the bank icon up but just no option to deposit or withdraw. only error i am getting is this which is spammed in local rpt Error in expression <rTarget in DZE_MoneyStorageClasses && {!_isLocked} && !(_typeOfCursorTarget in D> Error position: <_isLocked} && !(_typeOfCursorTarget in D> Error Undefined variable in expression: _islocked File mpmissions\__CUR_MP.chernarus\dayz_code\compile\fn_selfActions.sqf, line 941 Error in expression <rTarget in DZE_MoneyStorageClasses && {!_isLocked} && !(_typeOfCursorTarget in D> Error position: <_isLocked} && !(_typeOfCursorTarget in D> Error Undefined variable in expression: _islocked File mpmissions\__CUR_MP.chernarus\dayz_code\compile\fn_selfActions.sqf, line 941 Error in expression <rTarget in DZE_MoneyStorageClasses && {!_isLocked} && !(_typeOfCursorTarget in D> Error position: <_isLocked} && !(_typeOfCursorTarget in D> Error Undefined variable in expression: _islocked File mpmissions\__CUR_MP.chernarus\dayz_code\compile\fn_selfActions.sqf, line 941 Error in expression <rTarget in DZE_MoneyStorageClasses && {!_isLocked} && !(_typeOfCursorTarget in D> Error position: <_isLocked} && !(_typeOfCursorTarget in D> Error Undefined variable in expression: _islocked File mpmissions\__CUR_MP.chernarus\dayz_code\compile\fn_selfActions.sqf, line 941 its on a fresh install using the files from github that section from fn-self Reveal hidden contents // Custom below _isAnimal = _cursorTarget isKindOf "Animal"; if (_isMan && {!_isAlive} && {!_isAnimal} && {player distance _cursorTarget < 5}) then { if (s_player_checkWallet < 0) then { s_player_checkWallet = player addAction ["Check Wallet","scripts\zsc\checkWallet.sqf",_cursorTarget,0,false,true]; }; } else { player removeAction s_player_checkWallet; s_player_checkWallet = -1; }; if (_typeOfCursorTarget in DZE_MoneyStorageClasses && {!_isLocked} && !(_typeOfCursorTarget in DZE_LockedStorage) && {_isDistance}) then { if (s_bank_dialog < 0) then { s_bank_dialog = player addAction ["Access bank","scripts\zsc\bankDialog.sqf",_cursorTarget,1,true,true]; }; } else { player removeAction s_bank_dialog; s_bank_dialog = -1; }; if (_isAlive && {_typeOfCursorTarget in AllPlayers} && {isPlayer _cursorTarget}) then { if (s_givemoney_dialog < 0) then { s_givemoney_dialog = player addAction [format ["Trade %1 with %2",CurrencyName,name _cursorTarget],"scripts\zsc\givePlayer.sqf",_cursorTarget,3,true,true]; }; } else { player removeAction s_givemoney_dialog; s_givemoney_dialog = -1; }; thanks Hey, check GitHub, I just fixed that. It looks like I've merged in code from my server files by mistake thus the undefined variables. My mistake. Link to comment Share on other sites More sharing options...
OMGitzSteveo Posted March 14, 2017 Report Share Posted March 14, 2017 38 minutes ago, salival said: Also, I fixed 2 undefined variables in the fn_selfActions file this morning a few hours ago, be sure to update if it needs it, could fix that problem You're a legend mate. Your update has fixed the issue :D Finally something i didn't do wrong for a change haha Link to comment Share on other sites More sharing options...
Anhor Posted March 14, 2017 Report Share Posted March 14, 2017 I installed it on my server (1.0.6.1). Everything works so far very well......... the display of the coins on the right side is there and also shows how much coins I have. Also with the traders works the menu. But with some traders the inventory is empty. Black Market, Aircraft, Hero and Bandit working. Some of the standart traders works also. Maybe it is due to the installed map (Takistan). I have the supplied server_traders.sqf used, so was not even the dealer menu displayed. So I used instead my original server_trader.sqf, with the result described. This is the content of my original server_trader.sqf: #include "\z\addons\dayz_code\system\mission\server_traders\takistan.sqf" The only errors I see in the RPT: 21:52:56 "PRELOAD_ Functions\init [[<No group>:0 (FunctionsManager)],any]" 21:52:56 "MPframework inited" 21:52:56 "dayz_preloadFinished reset" 21:52:56 Error in expression <; _recompile = (count _this) > 0; if (BIS_fnc_init && !_recompile) exitwith {t> 21:52:56 Error position: <BIS_fnc_init && !_recompile) exitwith {t> 21:52:56 Error Undefined variable in expression: bis_fnc_init 21:52:56 File ca\Modules\Functions\init.sqf, line 28 21:52:57 "Loading custom server compiles" 21:52:57 BIKE: loading version 2.8.2 ... 21:52:57 BIKE: adding bike to safe vehicle list... 21:52:58 "z\addons\dayz_code\system\REsec.sqf:Monitoring Remote Exe..." 21:52:58 "HIVE: Starting" 21:52:59 "SERVER FPS: 36 PLAYERS: 1" 21:52:59 ["TIME SYNC: Local Time set to:",[2012,8,2,21,52],"Fullmoon:",true,"Date given by HiveExt.dll:",[2017,3,14,21,52]] 21:52:59 "HIVE: trying to get objects" 21:52:59 "HIVE: found 4 objects" 21:52:59 "HIVE: Request sent" 21:52:59 "HIVE: Streamed 4 objects" 21:52:59 "HIVE: BENCHMARK - Server_monitor.sqf finished streaming 4 objects in 0.162003 seconds (unscheduled)" 21:52:59 "Total Number of spawn locations 11" 21:53:01 "DEBUG: Spawning a care package (Misc_cargo_cont_net2) at [7735.27,12257.4,0] with 6 items." 21:53:01 "INFO - Player: PID#3(Anhor)(UID:76561198127974288/CID:2) Status: LOGGING IN" 21:53:01 "CRASHSPAWNER: Starting crash site spawner. Frequency: 25±20 min. Spawn chance: 0.75" 21:53:01 "CRASHSPAWNER: Spawning crash site (CrashSite_EU) at [7746.03,9108.82,0] with 8 items." 21:53:01 ["z\addons\dayz_server\system\scheduler\sched_sync.sqf","TIME SYNC: Local Time set to:",[2012,8,2,21,53],"Fullmoon:",true,"Date given by HiveExt.dll:",[2017,3,14,21,53]] 21:53:01 "CLEANUP: INITIALIZING Vehicle SCRIPT" 21:53:01 "EPOCH EVENTS INIT" Can anyone help me? Link to comment Share on other sites More sharing options...
stirrific Posted March 14, 2017 Report Share Posted March 14, 2017 u need to follow the install instructions In scripts\traders move or delete the file server_traders.sqf Rename server_traders - whatever-map-name.sqf to server_traders.sqf Link to comment Share on other sites More sharing options...
Anhor Posted March 15, 2017 Report Share Posted March 15, 2017 Excuse that English is not my mother tongue, at the moment it seems to me as if there are some steps in between. If I understand this correctly, then I must download the dayz_server.pbo, unpack and rename the takistan.sqf? Not to forget that the dayz_server.pbo has to be repackaged and uploaded. Is this what you propose? Link to comment Share on other sites More sharing options...
salival Posted March 15, 2017 Author Report Share Posted March 15, 2017 @Anhor I replied to you earlier but my reply must have not got sent, I made changes this morning to fix some errors that could be causing your problems, please check the GitHub and update Anhor 1 Link to comment Share on other sites More sharing options...
Anhor Posted March 15, 2017 Report Share Posted March 15, 2017 Will do, thx. Link to comment Share on other sites More sharing options...
Chuppah Posted March 15, 2017 Report Share Posted March 15, 2017 Spoiler Error in expression <s_bank_dialog = -1; player removeAction s_bank_dialog1; s_bank_dialog1 = -1; pla> Error position: <s_bank_dialog1; s_bank_dialog1 = -1; pla> Error Undefined variable in expression: s_bank_dialog1 File mpmissions\__CUR_MP.Chernarus\dayz_code\compile\fn_selfActions.sqf, line 1198 I keep getting kicked when interacting with banker npc due to battleye restriction #8 only error i could find within my rpt, any help would be awesome Link to comment Share on other sites More sharing options...
salival Posted March 15, 2017 Author Report Share Posted March 15, 2017 I'm guessing you didn't do step 7 under https://github.com/oiad/ZSC#changing-to-global-banking which explains how to add the battleye filter for the NPC As for the error log in your RPT, You need to make sure you are calling the custom variables.sqf, it looks like you aren't. You need to install ZSC as a base then global banking on top of it. Installing ZSC as the base will have the custom compiles.sqf and variables.sqf set up. Link to comment Share on other sites More sharing options...
Chuppah Posted March 15, 2017 Report Share Posted March 15, 2017 I managed to install zsc as a base without any problems, I may try redoing the steps for global banking. I did do step 7 to add the battleye filter in scripts.txt, I may have missed something with the global banking install, do I merge the contents of the custom compiles and variables.sqf to the existing zsc ones or do i call them seperately Link to comment Share on other sites More sharing options...
salival Posted March 15, 2017 Author Report Share Posted March 15, 2017 If you have nothing else in them apart from ZSC, you should be able to just copy them straight over the top. If you have other mod stuff in there, you will need to merge. Link to comment Share on other sites More sharing options...
Chuppah Posted March 15, 2017 Report Share Posted March 15, 2017 Ok will give that a crack, worst case senario ill start over, may have been an oversight on my part and I've skipped something along the way. Thank you Link to comment Share on other sites More sharing options...
salival Posted March 15, 2017 Author Report Share Posted March 15, 2017 Hey guys, I finally have vehicles saving coins properly, it was really easy once I finally got time to look at it. Here's the changes I've made here: https://github.com/oiad/ZSC/commit/4846420cc32edb691696f73c82a8de1e4aeb3986 To install this update: Copy and replace the server_updateObject.sqf to your dayz_server\compile Copy and replace the zscInit.sqf to your MPMission\scripts\zsc Link to comment Share on other sites More sharing options...
Recommended Posts